improvements: additional feedback

This commit is contained in:
Scott Wilson
2025-06-02 18:19:51 -07:00
parent 2be8c47ae8
commit d4523b0ca4
2 changed files with 10 additions and 5 deletions

View File

@@ -1,6 +1,3 @@
import { faExpand } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { createNotification } from "@app/components/notifications";
import { ProjectPermissionCan } from "@app/components/permissions";
import { Button } from "@app/components/v2";
@@ -63,7 +60,6 @@ export const SecretScanningResourceSection = ({ dataSource }: Props) => {
{(isAllowed) => (
<Button
colorSchema="secondary"
leftIcon={<FontAwesomeIcon icon={faExpand} />}
onClick={handleTriggerScan}
isDisabled={!isAllowed || triggerDataSourceScan.isPending}
isLoading={triggerDataSourceScan.isPending}

View File

@@ -1,3 +1,4 @@
import { RESOURCE_DESCRIPTION_HELPER } from "@app/helpers/secretScanningV2";
import { TSecretScanningDataSource } from "@app/hooks/api/secretScanningV2";
import { SecretScanningScanTable } from "./SecretScanningScanTable";
@@ -7,10 +8,18 @@ type Props = {
};
export const SecretScanningScanSection = ({ dataSource }: Props) => {
const resourceDetails = RESOURCE_DESCRIPTION_HELPER[dataSource.type];
return (
<div className="w-full rounded-lg border border-mineshaft-600 bg-mineshaft-900 p-4">
<div className="mb-4 flex items-center justify-between">
<p className="text-xl font-semibold text-mineshaft-100">Scan History</p>
<div>
<p className="text-xl font-semibold text-mineshaft-100">Scan History</p>
<p className="text-sm text-bunker-300">
Detailed history of when {resourceDetails.singularNoun} scans occurred and their
findings
</p>
</div>
</div>
<SecretScanningScanTable dataSource={dataSource} />
</div>