improvements: address greppy

frontend/src/components/projects/ProjectSettings/components/ProjectTemplatesTab/components/DeleteProjectTemplateModal.tsx

@@ -41,7 +41,7 @@ export const DeleteProjectTemplateModal = ({ isOpen, onOpenChange, template }: P
     <DeleteActionModal
       isOpen={isOpen}
       onChange={onOpenChange}
-      title={`Are you sure want to delete ${name}?`}
+      title={`Are you sure you want to delete ${name}?`}
       deleteKey="confirm"
       onDeleteApproved={handleDeleteProjectTemplate}
     />

frontend/src/components/projects/ProjectSettings/components/ProjectTemplatesTab/components/EditProjectTemplateSection/components/EditProjectTemplate.tsx

@@ -112,7 +112,7 @@ export const EditProjectTemplate = ({ isInfisicalTemplate, projectTemplate, onBa
       />
       <DeleteActionModal
         isOpen={popUp.removeTemplate.isOpen}
-        title={`Are you sure want to delete ${projectTemplate.name}?`}
+        title={`Are you sure you want to delete ${projectTemplate.name}?`}
         deleteKey="confirm"
         onChange={(isOpen) => handlePopUpToggle("removeTemplate", isOpen)}
         onDeleteApproved={handleRemoveTemplate}

frontend/src/components/secret-rotations-v2/DeleteSecretRotationV2Modal.tsx

@@ -66,7 +66,7 @@ export const DeleteSecretRotationV2Modal = ({
     <DeleteActionModal
       isOpen={isOpen}
       onChange={onOpenChange}
-      title={`Are you sure want to delete ${name}?`}
+      title={`Are you sure you want to delete ${name}?`}
       deleteKey={name}
       onDeleteApproved={handleDeleteSecretRotation}
     >

frontend/src/components/secret-scanning/DeleteSecretScanningDataSourceModal.tsx

@@ -19,7 +19,7 @@ export const DeleteSecretScanningDataSourceModal = ({
   dataSource,
   onComplete
 }: Props) => {
-  const deleteSecretRotation = useDeleteSecretScanningDataSource();
+  const deleteDataSource = useDeleteSecretScanningDataSource();
 
   if (!dataSource) return null;
 
@@ -29,7 +29,7 @@ export const DeleteSecretScanningDataSourceModal = ({
     const dataSourceType = SECRET_SCANNING_DATA_SOURCE_MAP[type].name;
 
     try {
-      await deleteSecretRotation.mutateAsync({
+      await deleteDataSource.mutateAsync({
         dataSourceId,
         type,
         projectId
@@ -54,7 +54,7 @@ export const DeleteSecretScanningDataSourceModal = ({
     <DeleteActionModal
       isOpen={isOpen}
       onChange={onOpenChange}
-      title={`Are you sure want to delete ${name}?`}
+      title={`Are you sure you want to delete ${name}?`}
       deleteKey={name}
       onDeleteApproved={handleDeleteDataSource}
     >

frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitHubDataSourceConfigFields.tsx

@@ -43,7 +43,7 @@ export const GitHubDataSourceConfigFields = () => {
     if (!includeRepos) {
       setValue("config.includeRepos", ["*"]);
     }
-  }, [includeRepos]);
+  }, [includeRepos, setValue]);
 
   return (
     <>

frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConnectionField.tsx

@@ -36,8 +36,6 @@ export const SecretScanningDataSourceConnectionField = ({
     OrgPermissionSubjects.AppConnections
   );
 
-  const appName = APP_CONNECTION_MAP[app].name;
-
   return (
     <>
       <Controller
@@ -89,14 +87,14 @@ export const SecretScanningDataSourceConnectionField = ({
           <FontAwesomeIcon className="mr-1" size="xs" icon={faInfoCircle} />
           {canCreateConnection ? (
             <>
-              You do not have access to any {appName} Connections. Create one from the{" "}
+              You do not have access to any {connectionName} Connections. Create one from the{" "}
               <Link to="/organization/app-connections" className="underline">
                 App Connections
               </Link>{" "}
               page.
             </>
           ) : (
-            `You do not have access to any ${appName} Connections. Contact an admin to create one.`
+            `You do not have access to any ${connectionName} Connections. Contact an admin to create one.`
           )}
         </p>
       )}

frontend/src/components/secret-scanning/forms/SecretScanningDataSourceForm.tsx

@@ -66,13 +66,13 @@ export const SecretScanningDataSourceForm = ({ type, onComplete, onCancel, dataS
           projectId: currentWorkspace.id
         });
     try {
-      const rotation = await mutation;
+      const source = await mutation;
 
       createNotification({
-        text: `Successfully ${dataSource ? "updated" : "created"} ${sourceType} Data Source`,
+        text: `Successfully ${source ? "updated" : "created"} ${sourceType} Data Source`,
         type: "success"
       });
-      onComplete(rotation);
+      onComplete(source);
     } catch (err: any) {
       createNotification({
         title: `Failed to ${dataSource ? "update" : "create"} ${sourceType} Data Source`,

frontend/src/components/secret-scanning/forms/schemas/github-data-source-schema.ts

@@ -8,7 +8,11 @@ export const GitHubDataSourceSchema = z
   .object({
     type: z.literal(SecretScanningDataSource.GitHub),
     config: z.object({
-      includeRepos: z.string().array().min(1, "One or more repositories required")
+      includeRepos: z
+        .string()
+        .array()
+        .min(1, "One or more repositories required")
+        .max(25, "Cannot configure more than 25 repositories")
     })
   })
   .merge(BaseSecretScanningDataSourceSchema({ isConnectionRequired: true }));

frontend/src/components/secret-syncs/DeleteSecretSyncModal.tsx

@@ -52,7 +52,7 @@ export const DeleteSecretSyncModal = ({ isOpen, onOpenChange, secretSync, onComp
     <DeleteActionModal
       isOpen={isOpen}
       onChange={onOpenChange}
-      title={`Are you sure want to delete ${name}?`}
+      title={`Are you sure you want to delete ${name}?`}
       deleteKey={name}
       onDeleteApproved={handleDeleteSecretSync}
     >