greptile review fixes

backend/src/db/migrations/20250903191434_audit-log-stream-v2.ts

@@ -198,7 +198,11 @@ export async function down(knex: Knex): Promise<void> {
         .merge();
     }
 
-    await knex(TableName.AuditLogStream).whereNot("provider", "custom").orWhereNull("url").del();
+    await knex(TableName.AuditLogStream)
+      .where((qb) => {
+        void qb.whereNot("provider", "custom").orWhereNull("url");
+      })
+      .del();
 
     await knex.schema.alterTable(TableName.AuditLogStream, (t) => {
       t.string("url").notNullable().alter();

backend/src/ee/routes/v1/index.ts

@@ -120,9 +120,11 @@ export const registerV1EERoutes = async (server: FastifyZodProvider) => {
       await auditLogStreamRouter.register(registerAuditLogStreamRouter);
 
       // Provider-specific endpoints
-      for await (const [provider, router] of Object.entries(AUDIT_LOG_STREAM_REGISTER_ROUTER_MAP)) {
-        await auditLogStreamRouter.register(router, { prefix: `/${provider}` });
-      }
+      await Promise.all(
+        Object.entries(AUDIT_LOG_STREAM_REGISTER_ROUTER_MAP).map(([provider, router]) =>
+          auditLogStreamRouter.register(router, { prefix: `/${provider}` })
+        )
+      );
     },
     { prefix: "/audit-log-streams" }
   );

backend/src/ee/services/audit-log-stream/custom/custom-provider-schemas.ts

@@ -1,3 +1,4 @@
+import RE2 from "re2";
 import { z } from "zod";
 
 import { LogProvider } from "../audit-log-stream-enums";
@@ -7,8 +8,14 @@ export const CustomProviderCredentialsSchema = z.object({
   url: z.string().url().trim().min(1).max(255),
   headers: z
     .object({
-      key: z.string().min(1),
-      value: z.string().min(1)
+      key: z
+        .string()
+        .min(1)
+        .refine((val) => new RE2(/^[^\n\r]+$/).test(val), "Header keys cannot contain newlines or carriage returns"),
+      value: z
+        .string()
+        .min(1)
+        .refine((val) => new RE2(/^[^\n\r]+$/).test(val), "Header values cannot contain newlines or carriage returns")
     })
     .array()
 });

backend/src/ee/services/audit-log-stream/splunk/splunk-provider-factory.ts

@@ -14,7 +14,7 @@ function createPayload(event: Record<string, unknown>) {
 
   return {
     time: Math.floor(Date.now() / 1000),
-    host: new URL(appCfg.SITE_URL || "http://infisical").host,
+    ...(appCfg.SITE_URL && { host: new URL(appCfg.SITE_URL).host }),
     source: "infisical",
     sourcetype: "_json",
     event
@@ -29,7 +29,7 @@ async function createSplunkUrl(hostname: string) {
     throw new BadRequestError({ message: `Invalid Splunk hostname provided: ${(error as Error).message}` });
   }
 
-  await blockLocalAndPrivateIpAddresses(`https://${hostname}`);
+  await blockLocalAndPrivateIpAddresses(`https://${parsedHostname}`);
 
   return `https://${parsedHostname}:8088/services/collector/event`;
 }

frontend/src/helpers/auditLogStreams.ts

@@ -13,6 +13,7 @@ export const AUDIT_LOG_STREAM_PROVIDER_MAP: Record<
   [LogProvider.Splunk]: { name: "Splunk", image: "Splunk.png", size: 65 }
 };
 
+// Strictly for showing to the client in the front-end
 export function getProviderUrl(
   logStream: DiscriminativePick<TAuditLogStream, "provider" | "credentials">
 ) {

frontend/src/hooks/api/auditLogStreams/mutations.tsx

@@ -16,7 +16,7 @@ export const useCreateAuditLogStream = () => {
     mutationFn: async ({ provider, ...params }: TCreateAuditLogStreamDTO) => {
       const { data } = await apiRequest.post<{ auditLogStream: TAuditLogStream }>(
         `/api/v1/audit-log-streams/${provider}`,
-        { ...params, provider }
+        params
       );
 
       return data.auditLogStream;

frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/components/AuditLogStreamTable.tsx

@@ -255,7 +255,7 @@ export const AuditLogStreamTable = () => {
             {isPending && (
               <TableSkeleton
                 innerKey="audit-log-streams-table"
-                columns={4}
+                columns={3}
                 key="audit-log-streams"
               />
             )}

frontend/src/pages/organization/SettingsPage/components/AuditLogStreamTab/components/LogStreamProviderSelect.tsx

@@ -92,7 +92,7 @@ export const LogStreamProviderSelect = ({ onSelect }: Props) => {
             </button>
           );
         })}
-        {!filteredOptions?.length && (
+        {!filteredOptions.length && (
           <EmptyState
             className="col-span-full mt-40"
             title="No providers match search"