Merge pull request #1363 from akhilmhdh/feat/audit-log-desc

feat: enabled order by desc for audit log and added sort for couple of get queries
This commit is contained in:
Maidul Islam
2024-02-02 12:07:57 -05:00
committed by GitHub
4 changed files with 6 additions and 4 deletions

View File

@@ -38,7 +38,8 @@ export const auditLogDALFactory = (db: TDbClient) => {
})
)
.limit(limit)
.offset(offset);
.offset(offset)
.orderBy("createdAt", "desc");
if (startDate) {
void sqlQuery.where("createdAt", ">=", startDate);
}

View File

@@ -47,7 +47,7 @@ export const secretTagServiceFactory = ({ secretTagDAL, permissionService }: TSe
const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.Tags);
const tags = await secretTagDAL.find({ projectId });
const tags = await secretTagDAL.find({ projectId }, { sort: [["createdAt", "asc"]] });
return tags;
};

View File

@@ -117,7 +117,7 @@ export const serviceTokenServiceFactory = ({
const { permission } = await permissionService.getProjectPermission(actor, actorId, projectId);
ForbiddenError.from(permission).throwUnlessCan(ProjectPermissionActions.Read, ProjectPermissionSub.ServiceTokens);
const tokens = await serviceTokenDAL.find({ projectId });
const tokens = await serviceTokenDAL.find({ projectId }, { sort: [["createdAt", "desc"]] });
return tokens;
};

View File

@@ -80,7 +80,8 @@ export const webhookDALFactory = (db: TDbClient) => {
.select(db.ref("slug").withSchema(TableName.Environment).as("envSlug"))
.select(db.ref("id").withSchema(TableName.Environment).as("envId"))
.select(db.ref("projectId").withSchema(TableName.Environment))
.select(selectAllTableCols(TableName.Webhook));
.select(selectAllTableCols(TableName.Webhook))
.orderBy(`${TableName.Webhook}.createdAt`, "asc");
return webhooks.map(({ envId, envSlug, envName, ...el }) => ({
...el,