Fix telemetry issue for signup secrets

This commit is contained in:
Tuan Dang
2023-08-23 17:37:01 +07:00
parent 8b381b2b80
commit c342b22d49
3 changed files with 10 additions and 11 deletions

View File

@@ -234,6 +234,9 @@ export const batchSecrets = async (req: Request, res: Response) => {
$inc: {
version: 1
},
$unset: {
'metadata.source': true as true
},
...u,
_id: new Types.ObjectId(u._id)
}
@@ -739,7 +742,6 @@ export const createSecrets = async (req: Request, res: Response) => {
* @returns
*/
export const getSecrets = async (req: Request, res: Response) => {
console.log("getSecrets");
/*
#swagger.summary = 'Read secrets'
#swagger.description = 'Read secrets from a project and environment'
@@ -968,12 +970,8 @@ export const getSecrets = async (req: Request, res: Response) => {
const postHogClient = await TelemetryService.getPostHogClient();
console.log("the fetched secrets: ", secrets);
console.log("postHogClient: ", postHogClient);
if (postHogClient) {
console.log("should capture!");
const test = postHogClient.capture({
postHogClient.capture({
event: "secrets pulled",
distinctId: await TelemetryService.getDistinctId({
authData: req.authData
@@ -987,8 +985,6 @@ export const getSecrets = async (req: Request, res: Response) => {
userAgent: req.headers?.["user-agent"]
}
});
console.log("test: ", test);
}
return res.status(200).send({

View File

@@ -568,15 +568,17 @@ export const getSecretsHelper = async ({
);
const postHogClient = await TelemetryService.getPostHogClient();
const numberOfSignupSecrets = (secrets.filter((secret) => secret?.metadata?.source === "signup")).length;
if (postHogClient) {
if (postHogClient && (secrets.length - numberOfSignupSecrets > 0)) {
postHogClient.capture({
event: "secrets pulled",
distinctId: await TelemetryService.getDistinctId({
authData
}),
properties: {
numberOfSecrets: secrets.length,
numberOfSecrets: secrets.length - numberOfSignupSecrets,
environment,
workspaceId,
folderId,

View File

@@ -38,7 +38,7 @@ const fetchProjectEncryptedSecrets = async (
folderId?: string,
secretPath?: string
) => {
const { data } = await apiRequest.get<{ secrets: EncryptedSecret[] }>("/api/v2/secrets", {
const { data } = await apiRequest.get<{ secrets: EncryptedSecret[] }>("/api/v3/secrets", {
params: {
environment: env,
workspaceId,
@@ -46,6 +46,7 @@ const fetchProjectEncryptedSecrets = async (
secretPath
}
});
return data.secrets;
};