requested changes

This commit is contained in:
Daniel Hougaard
2025-06-05 05:23:30 +04:00
parent a4c21d85ac
commit caa129b565
4 changed files with 8 additions and 6 deletions

View File

@@ -307,8 +307,7 @@ export const registerIdentityKubernetesRouter = async (server: FastifyZodProvide
if (
data.tokenReviewMode &&
data.tokenReviewMode === IdentityKubernetesAuthTokenReviewMode.Gateway &&
!data.gatewayId &&
data.tokenReviewMode !== undefined
!data.gatewayId
) {
ctx.addIssue({
path: ["gatewayId"],
@@ -316,7 +315,7 @@ export const registerIdentityKubernetesRouter = async (server: FastifyZodProvide
message: "When token review mode is set to Gateway, a gateway must be selected"
});
}
if (data.accessTokenMaxTTL && data.accessTokenTTL ? data.accessTokenTTL <= data.accessTokenMaxTTL : true) {
if (data.accessTokenMaxTTL && data.accessTokenTTL ? data.accessTokenTTL > data.accessTokenMaxTTL : false) {
ctx.addIssue({
path: ["accessTokenTTL"],
code: z.ZodIssueCode.custom,

View File

@@ -249,7 +249,11 @@ export const identityKubernetesAuthServiceFactory = ({
.catch((err) => {
if (err instanceof AxiosError) {
if (err.response) {
const { message } = err?.response?.data as unknown as { message?: string };
let { message } = err?.response?.data as unknown as { message?: string };
if (!message && typeof err.response.data === "string") {
message = err.response.data;
}
if (message) {
throw new UnauthorizedError({

View File

@@ -299,7 +299,7 @@ func GetCmdFlagOrEnv(cmd *cobra.Command, flag string, envNames []string) (string
}
if value == "" {
for _, env := range envNames {
value = os.Getenv(env)
value = strings.TrimSpace(os.Getenv(env))
if value != "" {
break
}

View File

@@ -322,7 +322,6 @@ export const IdentityKubernetesAuthForm = ({
isDisabled={!isAllowed}
value={value as string}
onValueChange={(v) => {
console.log("v", v);
if (v !== "") {
onChange(v);
}