awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix MAX_GENERATED_CREDENTIALS_LENGTH for azure credentials

Browse Source
This commit is contained in:
carlosmonastyrski
2025-04-21 10:14:55 -03:00
parent c403ffa9f6
commit ccd7b0062e
2 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
backend/src/ee/services/secret-rotation-v2/azure-client-secret/azure-client-secret-rotation-fns.ts
View File

@@ -37,15 +37,20 @@ export const azureClientSecretRotationFactory: TRotationFactory<
await blockLocalAndPrivateIpAddresses(endpoint);
const endDateTime = new Date();
console.log({ rotationInterval })
endDateTime.setDate(endDateTime.getDate() + rotationInterval);
const now = new Date();
const formattedDate = `${String(now.getMonth() + 1).padStart(2, "0")}-${String(now.getDate()).padStart(
2,
"0"
)}-${now.getFullYear()}`;
try {
const { data } = await request.post<AzureAddPasswordResponse>(
endpoint,
{
passwordCredential: {
displayName: "Infisical Auto-Rotated Secret",
displayName: `Infisical Rotated Secret (${formattedDate})`,
endDateTime: endDateTime.toISOString()
}
},

10
backend/src/ee/services/secret-rotation-v2/secret-rotation-v2-service.ts
View File

@@ -815,6 +815,14 @@ export const secretRotationV2ServiceFactory = ({
return expandSecretRotation(secretRotation, kmsService);
};
const getMaxGeneratedCredentialsLength = (rotationType: SecretRotation): number => {
if (rotationType === SecretRotation.AzureClientSecret) {
return 1;
}
return MAX_GENERATED_CREDENTIALS_LENGTH;
};
const rotateGeneratedCredentials = async (
secretRotation: TSecretRotationV2Raw,
{
@@ -858,7 +866,7 @@ export const secretRotationV2ServiceFactory = ({
kmsService
});
const inactiveIndex = (activeIndex + 1) % MAX_GENERATED_CREDENTIALS_LENGTH;
const inactiveIndex = (activeIndex + 1) % getMaxGeneratedCredentialsLength(type as SecretRotation);
const inactiveCredentials = generatedCredentials[inactiveIndex];