Review fixes

backend/src/ee/services/secret-rotation-v2/okta-client-secret/okta-client-secret-rotation-fns.ts

@@ -46,6 +46,9 @@ const createErrorMessage = (error: unknown) => {
   return "Unknown error";
 };
 
+// Delay between each revocation call in revokeCredentials
+const DELAY_MS = 1000;
+
 export const oktaClientSecretRotationFactory: TRotationFactory<
   TOktaClientSecretRotationWithConnection,
   TOktaClientSecretRotationGeneratedCredentials
@@ -182,6 +185,16 @@ export const oktaClientSecretRotationFactory: TRotationFactory<
         }
       });
     } catch (error: unknown) {
+      if (
+        error instanceof AxiosError &&
+        error.response?.data &&
+        isOktaErrorResponse(error.response.data) &&
+        error.response.data.errorCode === "E0000001"
+      ) {
+        // If this is the last secret, we cannot revoke it
+        return;
+      }
+
       throw new BadRequestError({
         message: `Failed to remove client secret with secretId ${secretId} from app ${clientId}: ${createErrorMessage(error)}`
       });
@@ -209,7 +222,7 @@ export const oktaClientSecretRotationFactory: TRotationFactory<
 
     for (const { secretId } of credentials) {
       await revokeCredential(secretId);
-      await delayMs(1000);
+      await delayMs(DELAY_MS);
     }
     return callback();
   };

backend/src/services/app-connection/okta/okta-connection-types.ts

@@ -25,5 +25,5 @@ export type TOktaApp = {
   id: string;
   label: string;
   status: "ACTIVE" | "INACTIVE";
-  name: string; // "oidc_client" or other types
+  name: "oidc_client"; // "oidc_client" or other types
 };