move enums to their own file + lint

backend/src/ee/routes/v1/pam-account-routers/pam-account-router.ts

@@ -2,7 +2,7 @@ import { z } from "zod";
 
 import { PamFoldersSchema } from "@app/db/schemas";
 import { EventType } from "@app/ee/services/audit-log/audit-log-types";
-import { PamAccountOrderBy, PamAccountView } from "@app/ee/services/pam-account/pam-account-types";
+import { PamAccountOrderBy, PamAccountView } from "@app/ee/services/pam-account/pam-account-enums";
 import { SanitizedMySQLAccountWithResourceSchema } from "@app/ee/services/pam-resource/mysql/mysql-resource-schemas";
 import { PamResource } from "@app/ee/services/pam-resource/pam-resource-enums";
 import { SanitizedPostgresAccountWithResourceSchema } from "@app/ee/services/pam-resource/postgres/postgres-resource-schemas";

backend/src/ee/services/pam-account/pam-account-dal.ts

@@ -6,7 +6,7 @@ import { DatabaseError } from "@app/lib/errors";
 import { ormify, selectAllTableCols } from "@app/lib/knex";
 import { OrderByDirection } from "@app/lib/types";
 
-import { PamAccountOrderBy, PamAccountView } from "./pam-account-types";
+import { PamAccountOrderBy, PamAccountView } from "./pam-account-enums";
 
 export type TPamAccountDALFactory = ReturnType<typeof pamAccountDALFactory>;
 

backend/src/ee/services/pam-account/pam-account-enums.ts

@@ -0,0 +1,8 @@
+export enum PamAccountOrderBy {
+  Name = "name"
+}
+
+export enum PamAccountView {
+  Flat = "flat",
+  Nested = "nested"
+}

backend/src/ee/services/pam-account/pam-account-service.ts

@@ -31,14 +31,9 @@ import { TPamSessionDALFactory } from "../pam-session/pam-session-dal";
 import { PamSessionStatus } from "../pam-session/pam-session-enums";
 import { OrgPermissionGatewayActions, OrgPermissionSubjects } from "../permission/org-permission";
 import { TPamAccountDALFactory } from "./pam-account-dal";
+import { PamAccountView } from "./pam-account-enums";
 import { decryptAccount, decryptAccountCredentials, encryptAccountCredentials } from "./pam-account-fns";
-import {
-  PamAccountView,
-  TAccessAccountDTO,
-  TCreateAccountDTO,
-  TListAccountsDTO,
-  TUpdateAccountDTO
-} from "./pam-account-types";
+import { TAccessAccountDTO, TCreateAccountDTO, TListAccountsDTO, TUpdateAccountDTO } from "./pam-account-types";
 
 type TPamAccountServiceFactoryDep = {
   pamResourceDAL: TPamResourceDALFactory;

backend/src/ee/services/pam-account/pam-account-types.ts

@@ -1,6 +1,7 @@
 import { OrderByDirection, TProjectPermission } from "@app/lib/types";
 
 import { TPamAccount } from "../pam-resource/pam-resource-types";
+import { PamAccountOrderBy, PamAccountView } from "./pam-account-enums";
 
 // DTOs
 export type TCreateAccountDTO = Pick<
@@ -30,12 +31,3 @@ export type TListAccountsDTO = {
   limit?: number;
   offset?: number;
 } & TProjectPermission;
-
-export enum PamAccountOrderBy {
-  Name = "name"
-}
-
-export enum PamAccountView {
-  Flat = "flat",
-  Nested = "nested"
-}

backend/src/ee/services/pam-folder/pam-folder-dal.ts

@@ -6,7 +6,7 @@ import { DatabaseError } from "@app/lib/errors";
 import { ormify, selectAllTableCols } from "@app/lib/knex";
 import { OrderByDirection } from "@app/lib/types";
 
-import { PamAccountOrderBy } from "../pam-account/pam-account-types";
+import { PamAccountOrderBy } from "../pam-account/pam-account-enums";
 
 export type TPamFolderDALFactory = ReturnType<typeof pamFolderDALFactory>;
 export const pamFolderDALFactory = (db: TDbClient) => {