awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(rbac): resolved batch bug in permission check

Browse Source
This commit is contained in:
Akhil Mohan
2023-09-08 19:46:24 +05:30
parent 43735b8183
commit e8f7b0c181
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/controllers/v2/secretsController.ts
View File

@@ -163,19 +163,19 @@ export const batchSecrets = async (req: Request, res: Response) => {
// not using service token using auth
if (!(req.authData.authPayload instanceof ServiceTokenData)) {
const { permission } = await getUserProjectPermissions(req.user._id, workspaceId);
if (!createSecrets.length)
if (createSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Create,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
if (!updateSecrets.length)
if (updateSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Edit,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
if (!deleteSecrets.length)
if (deleteSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Delete,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })

4
frontend/src/views/DashboardPage/DashboardPage.tsx
View File

@@ -333,6 +333,10 @@ export const DashboardPage = () => {
permission.cannot(
ProjectPermissionActions.Edit,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
) &&
permission.cannot(
ProjectPermissionActions.Create,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
const canDoRollback = !isReadOnly;

4
frontend/src/views/DashboardPage/components/SecretInputRow/SecretInputRow.tsx
View File

@@ -304,10 +304,6 @@ export const SecretInputRow = memo(
(isOverridden ? isAddOnly : shouldBeBlockedInAddOnly)
}
{...field}
onChange={(val) => {
console.log(val);
field.onChange(val);
}}
/>
)}
/>