feat(rbac): resolved batch bug in permission check

This commit is contained in:
Akhil Mohan
2023-09-08 21:22:36 +05:30
parent 43735b8183
commit e8f7b0c181
3 changed files with 7 additions and 7 deletions
@@ -163,19 +163,19 @@ export const batchSecrets = async (req: Request, res: Response) => {
// not using service token using auth
if (!(req.authData.authPayload instanceof ServiceTokenData)) {
const { permission } = await getUserProjectPermissions(req.user._id, workspaceId);
if (!createSecrets.length)
if (createSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Create,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
if (!updateSecrets.length)
if (updateSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Edit,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })
);
if (!deleteSecrets.length)
if (deleteSecrets.length)
ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Delete,
subject(ProjectPermissionSub.Secrets, { environment, secretPath })