awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-09-22 13:39:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fixed wrong naming for error handler middleware

Browse Source
This commit is contained in:
Hüseyin Berke Bütün
2022-12-24 21:45:53 +01:00
parent 6216f70950
commit 22d6aa8e46
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
backend/src/app.ts
View File

@@ -29,8 +29,9 @@ import {
integrationAuth as integrationAuthRouter
} from './routes';
import { getLogger } from './utils/logger';
import { catchUnroutedRequests } from './middleware/catchUnroutedRequests';
import { RouteNotFoundError } from './utils/errors';
import { errorHandler } from '@sentry/node/types/handlers';
import { requestErrorHandler } from './middleware/requestErrorHandler';
export const app = express();
@@ -80,7 +81,7 @@ app.use((req, res, next)=>{
})
//* Error Handling Middleware (must be after all routing logic)
app.use(catchUnroutedRequests)
app.use(requestErrorHandler)
export const server = app.listen(PORT, () => {

2
backend/src/middleware/catchUnroutedRequests.ts → backend/src/middleware/requestErrorHandler.ts
View File

@@ -6,7 +6,7 @@ import { getLogger } from "../utils/logger";
import RequestError, { LogLevel } from "../utils/requestError";
export const catchUnroutedRequests: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => {
export const requestErrorHandler: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => {
if(res.headersSent) return next();
//TODO: Find better way to type check for error. In current setting you need to cast type to get the functions and variables from RequestError
if(!(error instanceof RequestError)){