fix: Fixed wrong naming for error handler middleware

This commit is contained in:
Hüseyin Berke Bütün
2022-12-24 21:45:53 +01:00
parent 6216f70950
commit 22d6aa8e46
2 changed files with 4 additions and 3 deletions
+3 -2
View File
@@ -29,8 +29,9 @@ import {
integrationAuth as integrationAuthRouter integrationAuth as integrationAuthRouter
} from './routes'; } from './routes';
import { getLogger } from './utils/logger'; import { getLogger } from './utils/logger';
import { catchUnroutedRequests } from './middleware/catchUnroutedRequests';
import { RouteNotFoundError } from './utils/errors'; import { RouteNotFoundError } from './utils/errors';
import { errorHandler } from '@sentry/node/types/handlers';
import { requestErrorHandler } from './middleware/requestErrorHandler';
export const app = express(); export const app = express();
@@ -80,7 +81,7 @@ app.use((req, res, next)=>{
}) })
//* Error Handling Middleware (must be after all routing logic) //* Error Handling Middleware (must be after all routing logic)
app.use(catchUnroutedRequests) app.use(requestErrorHandler)
export const server = app.listen(PORT, () => { export const server = app.listen(PORT, () => {
@@ -6,7 +6,7 @@ import { getLogger } from "../utils/logger";
import RequestError, { LogLevel } from "../utils/requestError"; import RequestError, { LogLevel } from "../utils/requestError";
export const catchUnroutedRequests: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => { export const requestErrorHandler: ErrorRequestHandler = (error: RequestError|Error, req, res, next) => {
if(res.headersSent) return next(); if(res.headersSent) return next();
//TODO: Find better way to type check for error. In current setting you need to cast type to get the functions and variables from RequestError //TODO: Find better way to type check for error. In current setting you need to cast type to get the functions and variables from RequestError
if(!(error instanceof RequestError)){ if(!(error instanceof RequestError)){