improvements: final feedback

This commit is contained in:
Scott Wilson
2025-09-18 17:29:57 -07:00
parent 1a995b6f79
commit 37018581ef
2 changed files with 6 additions and 2 deletions

View File

@@ -403,6 +403,7 @@ export const SecretDetailSidebar = ({
isLoadingSecretValue ||
isErrorFetchingSecretValue
}
canEditButNotView={secret.secretValueHidden && canEditSecretValue}
environment={environment}
secretPath={secretPath}
key="secret-value"
@@ -703,6 +704,7 @@ export const SecretDetailSidebar = ({
<div className="thin-scrollbar flex flex-1 flex-col space-y-2 overflow-y-auto overflow-x-hidden rounded-md border border-mineshaft-600 bg-mineshaft-900 p-4 dark:[color-scheme:dark]">
{secretVersion?.map((version) => (
<SecretVersionItem
canReadValue={!cannotReadSecretValue}
secretVersion={version}
secret={secret}
currentVersion={secretVersion.length}

View File

@@ -24,13 +24,15 @@ interface SecretVersionItemProps {
secret: SecretV3RawSanitized;
currentVersion: number;
onRevert: (secretValue: string) => void;
canReadValue: boolean;
}
export const SecretVersionItem = ({
secretVersion: { createdAt, version, actor, secretValueHidden },
secret,
currentVersion,
onRevert
onRevert,
canReadValue
}: SecretVersionItemProps) => {
const { currentProject } = useProject();
@@ -244,7 +246,7 @@ export const SecretVersionItem = ({
</div>
</div>
</div>
{!secret?.isRotatedSecret && (
{!secret?.isRotatedSecret && canReadValue && (
<div
className={`flex items-center justify-center ${version === currentVersion ? "hidden" : ""}`}
>