awatertrevi/infisical
1
0
Fork 0
mirror of https://github.com/awatertrevi/infisical.git synced 2026-10-08 22:28:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

improvements: final feedback

Browse Source
This commit is contained in:
Scott Wilson
2025-09-18 17:29:57 -07:00
parent 1a995b6f79
commit 37018581ef
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretDetailSidebar.tsx
+2
View File
@@ -403,6 +403,7 @@ export const SecretDetailSidebar = ({
isLoadingSecretValue || isLoadingSecretValue ||
isErrorFetchingSecretValue isErrorFetchingSecretValue
} }
canEditButNotView={secret.secretValueHidden && canEditSecretValue}
environment={environment} environment={environment}
secretPath={secretPath} secretPath={secretPath}
key="secret-value" key="secret-value"
@@ -703,6 +704,7 @@ export const SecretDetailSidebar = ({
<div className="thin-scrollbar flex flex-1 flex-col space-y-2 overflow-y-auto overflow-x-hidden rounded-md border border-mineshaft-600 bg-mineshaft-900 p-4 dark:[color-scheme:dark]"> <div className="thin-scrollbar flex flex-1 flex-col space-y-2 overflow-y-auto overflow-x-hidden rounded-md border border-mineshaft-600 bg-mineshaft-900 p-4 dark:[color-scheme:dark]">
{secretVersion?.map((version) => ( {secretVersion?.map((version) => (
<SecretVersionItem <SecretVersionItem
canReadValue={!cannotReadSecretValue}
secretVersion={version} secretVersion={version}
secret={secret} secret={secret}
currentVersion={secretVersion.length} currentVersion={secretVersion.length}
frontend/src/pages/secret-manager/SecretDashboardPage/components/SecretListView/SecretVersionItem.tsx
+4 -2
View File
@@ -24,13 +24,15 @@ interface SecretVersionItemProps {
secret: SecretV3RawSanitized; secret: SecretV3RawSanitized;
currentVersion: number; currentVersion: number;
onRevert: (secretValue: string) => void; onRevert: (secretValue: string) => void;
canReadValue: boolean;
} }
export const SecretVersionItem = ({ export const SecretVersionItem = ({
secretVersion: { createdAt, version, actor, secretValueHidden }, secretVersion: { createdAt, version, actor, secretValueHidden },
secret, secret,
currentVersion, currentVersion,
onRevert onRevert,
canReadValue
}: SecretVersionItemProps) => { }: SecretVersionItemProps) => {
const { currentProject } = useProject(); const { currentProject } = useProject();
@@ -244,7 +246,7 @@ export const SecretVersionItem = ({
</div> </div>
</div> </div>
</div> </div>
{!secret?.isRotatedSecret && ( {!secret?.isRotatedSecret && canReadValue && (
<div <div
className={`flex items-center justify-center ${version === currentVersion ? "hidden" : ""}`} className={`flex items-center justify-center ${version === currentVersion ? "hidden" : ""}`}
> >