feat(secrets-ui): allow read access to personal overrides

This commit is contained in:
carlosmonastyrski
2025-04-25 20:41:44 -03:00
parent f460acf9b4
commit c229d6888c
3 changed files with 4 additions and 4 deletions

View File

@@ -2,7 +2,7 @@ import path from "node:path";
import RE2 from "re2";
import { TableName, TSecretFolders, TSecretsV2 } from "@app/db/schemas";
import { SecretType, TableName, TSecretFolders, TSecretsV2 } from "@app/db/schemas";
import { ForbiddenRequestError, NotFoundError } from "@app/lib/errors";
import { groupBy } from "@app/lib/fn";
import { logger } from "@app/lib/logger";
@@ -717,7 +717,7 @@ export const reshapeBridgeSecret = (
rotationId: secret.rotationId,
...(secretValueHidden
? {
secretValue: INFISICAL_SECRET_VALUE_HIDDEN_MASK,
secretValue: secret.type === SecretType.Personal ? secret.value : INFISICAL_SECRET_VALUE_HIDDEN_MASK,
secretValueHidden: true
}
: {

View File

@@ -125,7 +125,7 @@ export const SecretEditRow = ({
);
}
}
if (secretValueHidden) {
if (secretValueHidden && !isOverride) {
setTimeout(() => {
reset({ value: defaultValue || null });
}, 50);

View File

@@ -86,7 +86,7 @@ export const SecretOverviewTableRow = ({
})
);
if (secret?.secretValueHidden) {
if (secret?.secretValueHidden && !secret?.valueOverride) {
return canEditSecretValue ? "******" : "";
}
return secret?.valueOverride || secret?.value || importedSecret?.secret?.value || "";