mirror of
https://github.com/awatertrevi/infisical.git
synced 2026-10-03 08:26:00 +00:00
feat(secrets-ui): minor improvements from PR suggestions
This commit is contained in:
+18
-37
@@ -87,7 +87,6 @@ export const SecretEditRow = ({
|
||||
const { permission } = useProjectPermission();
|
||||
|
||||
const [isDeleting, setIsDeleting] = useToggle();
|
||||
const [isSecretBlurFocus, setIsSecretBlurFocus] = useToggle(false);
|
||||
const [isModalOpen, setIsModalOpen] = useState<boolean>(false);
|
||||
|
||||
const toggleModal = useCallback(() => {
|
||||
@@ -129,7 +128,6 @@ export const SecretEditRow = ({
|
||||
setTimeout(() => {
|
||||
reset({ value: defaultValue || null });
|
||||
}, 50);
|
||||
setIsSecretBlurFocus.off();
|
||||
} else {
|
||||
reset({ value });
|
||||
}
|
||||
@@ -150,12 +148,6 @@ export const SecretEditRow = ({
|
||||
})
|
||||
);
|
||||
|
||||
const handleSecretBlurClick = () => {
|
||||
if (canEditSecretValue) {
|
||||
setIsSecretBlurFocus.toggle();
|
||||
}
|
||||
};
|
||||
|
||||
const handleDeleteSecret = useCallback(async () => {
|
||||
setIsDeleting.on();
|
||||
setIsModalOpen(false);
|
||||
@@ -185,35 +177,24 @@ export const SecretEditRow = ({
|
||||
</Tooltip>
|
||||
)}
|
||||
<div className="flex-grow border-r border-r-mineshaft-600 pl-1 pr-2">
|
||||
{secretValueHidden && !isSecretBlurFocus ? (
|
||||
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
|
||||
<div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
|
||||
<span className="flex flex-row items-center">
|
||||
<div style={{ fontFamily: "monospace" }} className="h-full w-full">
|
||||
******
|
||||
</div>
|
||||
</span>
|
||||
</div>
|
||||
) : (
|
||||
<Controller
|
||||
disabled={isImportedSecret && !defaultValue}
|
||||
control={control}
|
||||
name="value"
|
||||
render={({ field }) => (
|
||||
<InfisicalSecretInput
|
||||
{...field}
|
||||
isReadOnly={isImportedSecret || isRotatedSecret}
|
||||
value={field.value as string}
|
||||
key="secret-input"
|
||||
isVisible={isVisible && !secretValueHidden}
|
||||
secretPath={secretPath}
|
||||
environment={environment}
|
||||
isImport={isImportedSecret}
|
||||
defaultValue={secretValueHidden ? "" : undefined}
|
||||
/>
|
||||
)}
|
||||
/>
|
||||
)}
|
||||
<Controller
|
||||
disabled={isImportedSecret && !defaultValue}
|
||||
control={control}
|
||||
name="value"
|
||||
render={({ field }) => (
|
||||
<InfisicalSecretInput
|
||||
{...field}
|
||||
isReadOnly={isImportedSecret || isRotatedSecret}
|
||||
value={field.value as string}
|
||||
key="secret-input"
|
||||
isVisible={isVisible && !secretValueHidden}
|
||||
secretPath={secretPath}
|
||||
environment={environment}
|
||||
isImport={isImportedSecret}
|
||||
defaultValue={secretValueHidden ? "" : undefined}
|
||||
/>
|
||||
)}
|
||||
/>
|
||||
</div>
|
||||
|
||||
<div
|
||||
|
||||
-16
@@ -95,7 +95,6 @@ export const SecretItem = memo(
|
||||
const { currentWorkspace } = useWorkspace();
|
||||
const { permission } = useProjectPermission();
|
||||
const { isRotatedSecret } = secret;
|
||||
const [isSecretBlurFocus, setIsSecretBlurFocus] = useToggle(false);
|
||||
|
||||
const canEditSecretValue = permission.can(
|
||||
ProjectPermissionSecretActions.Edit,
|
||||
@@ -189,12 +188,6 @@ export const SecretItem = memo(
|
||||
overrideAction === SecretActionType.Created || overrideAction === SecretActionType.Modified;
|
||||
const hasTagsApplied = Boolean(fields.length);
|
||||
|
||||
const handleSecretBlurClick = () => {
|
||||
if (canEditSecretValue) {
|
||||
setIsSecretBlurFocus.toggle();
|
||||
}
|
||||
};
|
||||
|
||||
const handleOverrideClick = () => {
|
||||
if (isOverriden) {
|
||||
// override need not be flagged delete if it was never saved in server
|
||||
@@ -334,15 +327,6 @@ export const SecretItem = memo(
|
||||
/>
|
||||
)}
|
||||
/>
|
||||
) : secretValueHidden && !isSecretBlurFocus ? (
|
||||
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
|
||||
<div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
|
||||
<span className="flex flex-row items-center">
|
||||
<div style={{ fontFamily: "monospace" }} className="h-full w-full">
|
||||
{hiddenValue}
|
||||
</div>
|
||||
</span>
|
||||
</div>
|
||||
) : (
|
||||
<Controller
|
||||
name="value"
|
||||
|
||||
-2
@@ -49,8 +49,6 @@ export const SecretListView = ({
|
||||
isProtectedBranch = false,
|
||||
importedBy
|
||||
}: Props) => {
|
||||
console.log("secretssssss", secrets);
|
||||
|
||||
const queryClient = useQueryClient();
|
||||
const { popUp, handlePopUpToggle, handlePopUpOpen, handlePopUpClose } = usePopUp([
|
||||
"deleteSecret",
|
||||
|
||||
Reference in New Issue
Block a user