feat(secrets-ui): minor improvements from PR suggestions

This commit is contained in:
carlosmonastyrski
2025-04-28 16:49:29 -03:00
parent 4fa7ba2ec7
commit f9c936865a
3 changed files with 18 additions and 55 deletions
@@ -95,7 +95,6 @@ export const SecretItem = memo(
const { currentWorkspace } = useWorkspace();
const { permission } = useProjectPermission();
const { isRotatedSecret } = secret;
const [isSecretBlurFocus, setIsSecretBlurFocus] = useToggle(false);
const canEditSecretValue = permission.can(
ProjectPermissionSecretActions.Edit,
@@ -189,12 +188,6 @@ export const SecretItem = memo(
overrideAction === SecretActionType.Created || overrideAction === SecretActionType.Modified;
const hasTagsApplied = Boolean(fields.length);
const handleSecretBlurClick = () => {
if (canEditSecretValue) {
setIsSecretBlurFocus.toggle();
}
};
const handleOverrideClick = () => {
if (isOverriden) {
// override need not be flagged delete if it was never saved in server
@@ -334,15 +327,6 @@ export const SecretItem = memo(
/>
)}
/>
) : secretValueHidden && !isSecretBlurFocus ? (
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
<div className="flex flex-grow items-center gap-2" onClick={handleSecretBlurClick}>
<span className="flex flex-row items-center">
<div style={{ fontFamily: "monospace" }} className="h-full w-full">
{hiddenValue}
</div>
</span>
</div>
) : (
<Controller
name="value"
@@ -49,8 +49,6 @@ export const SecretListView = ({
isProtectedBranch = false,
importedBy
}: Props) => {
console.log("secretssssss", secrets);
const queryClient = useQueryClient();
const { popUp, handlePopUpToggle, handlePopUpOpen, handlePopUpClose } = usePopUp([
"deleteSecret",